Remove proton/neutron Number #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
added
EXT: ED-PIC
We do in manual post-processing from time to time.
Yes, it does check its type. We need to remove these two lines: openPMD/openPMD-validator#39
I would like to hold this PR until we have a data converter PR for it. This way of working we will only merge changes to the standard that we can also convert to :) (The data conversion will need to implement a periodic table lookup, that's fun! :-p ) |
ax3l
reviewed
Apr 24, 2018
| The following additional attributes are defined in this extension. | ||
| The individual requirement is given in `scope`. | ||
|
|
||
| Note that the attributes below to not include information about the species |
There was a problem hiding this comment.
to -> do
Suggested change
| Note that the attributes below to not include information about the species | |
| Note that the attributes below do not include information about the species |
ax3l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the proton/neutron number from the
ED-PICextension, since it is now possible to specify it withSpeciesType.Implements issue: Close #191
Affected Components
EXT_ED-PICLogic Changes
Expressing ions in
ED-PICcan now be done by using theSpeciesTypeextension.Writer Changes
Data writers that were writing the proton/neutron number should now use the
SpeciesTypeextension.This might require a lookup of an element name in the periodic table for the naming. Previously, one could just define two numbers without knowing how an ion/isotope is abbreviated in the periodic table.
Reader Changes
I am not aware of any reader that currently checks this attribute, but in theory data readers should now look at the
SpeciesTypeinformation.openPMD-validator: remove check inED-PICED-PIC: Remove proton/neutron Number openPMD-validator#39Data Converter
Data converters should switch to using the
SpeciesType.